Skip to content

Cherry-Pick -enable-swifttail-musttail-check flag #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

etcwilde
Copy link

This is a cherry-pick of #2766 onto the swift/next branch.

Resolves: rdar://78628967

… calls.

When -enable-swifttailcc-musttail-check is passed (off by default), we will
check that all swiftasync->swiftasync tail calls are marked musttail.

Fixes rdar://75899279.
@etcwilde etcwilde added the swift-next Requests for fixing swift/next branch label May 28, 2021
@etcwilde etcwilde requested review from hyp and varungandhi-apple May 28, 2021 20:48
Copy link

@varungandhi-apple varungandhi-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this have come in through an automerger? I'm surprised as to why next needs to updated manually for this flag...

@varungandhi-apple
Copy link

Ah, nvm, I originally landed it on apple/stable, and there's no automerger from there to next.

@varungandhi-apple
Copy link

There's one more change related to this though with NDEBUG.

@varungandhi-apple
Copy link

#3004 <- You can cherry-pick this too for consistency.

@etcwilde
Copy link
Author

There's one more change related to this though with NDEBUG.

That's why I requested your review. Thanks for noting that.

@etcwilde
Copy link
Author

#3004 <- You can cherry-pick this too for consistency.

Commit cherry-picked. Thanks!

@etcwilde etcwilde merged commit b9e6492 into swiftlang:swift/next Jun 7, 2021
@etcwilde etcwilde deleted the swift-next/cherry-pick-swifttailcc-musttail branch January 26, 2022 16:37
swift-ci pushed a commit that referenced this pull request Dec 5, 2023
When all the large const offsets masked with the same value from bit-12 to bit-23.
Fold
  add     x8, x0, #2031, lsl #12
  add     x8, x8, #960
  ldr     x9, [x8, x8]
  ldr     x8, [x8, #2056]

into
  add     x8, x0, #2031, lsl #12
  ldr     x9, [x8, #960]
  ldr     x8, [x8, #3016]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
swift-next Requests for fixing swift/next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants