Skip to content

TypeSystem: silence some errors identified by MSVC #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2020
Merged

TypeSystem: silence some errors identified by MSVC #1993

merged 1 commit into from
Oct 26, 2020

Conversation

compnerd
Copy link
Member

Silence a few cases where MSVC complains about not all paths returning a
value. Avoid adding a default case to allow for catching covered
switches.

@compnerd
Copy link
Member Author

CC: @JDevlieghere @adrian-prantl @kastiglione

@compnerd
TypeSystem: silence some errors identified by MSVC
0180055 
Silence a few cases where MSVC complains about not all paths returning a
value.  Avoid adding a default case to allow for catching covered
switches.
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@kastiglione ping

@kastiglione
Copy link

kastiglione commented Oct 26, 2020 •
edited
Loading

sorry for letting this slip

@compnerd compnerd merged commit 46170cc into swiftlang:swift/main Oct 26, 2020
@compnerd compnerd deleted the coverage branch October 26, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kastiglione kastiglione kastiglione approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compnerd @kastiglione