Skip to content

Don't use hardcoded port for MockServer #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2024
Merged

Don't use hardcoded port for MockServer #350

merged 2 commits into from
Aug 30, 2024

Conversation

fabianfett
Copy link
Member

For the MockServer we should not use a hardcoded port.

Motivation:

  • We want to be able to run unit tests in parallel

Modifications:

  • The MockServer can now pick its own port and report the port it picked back to the user.

Result:

Tests can run in parallel.

@fabianfett fabianfett requested a review from FranzBusch August 30, 2024 16:04
@fabianfett fabianfett enabled auto-merge (squash) August 30, 2024 16:30
@fabianfett fabianfett disabled auto-merge August 30, 2024 16:30
@fabianfett fabianfett merged commit 223c3ba into main Aug 30, 2024
11 of 21 checks passed
@fabianfett fabianfett deleted the ff-fix-mockserver-port branch August 30, 2024 17:35
@fabianfett fabianfett added this to the 2.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @FranzBusch