Skip to content

split events into spearate package #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Jul 30, 2021

motivation: the runtime library has a stabel API while the events are still moving target, so in order to provide a 1.0 stable version we should separate them out

changes:

  • remove Events module
  • update readme
  • update Samples

@tomerd tomerd requested a review from fabianfett July 30, 2021 18:46
@tomerd
Copy link
Contributor Author

tomerd commented Jul 30, 2021

cc @bmoffatt @kneekey23

@tomerd tomerd added the ⚠️ semver/major Breaks existing public API. label Jul 30, 2021
@tomerd tomerd added this to the 1.0.0-alpha.1 milestone Jul 30, 2021
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However we should have an "integration" test target in AWSLambdaEvents that ensures that the examples in the runtime still compile after a change in events.

@tomerd
Copy link
Contributor Author

tomerd commented Aug 12, 2021

Looks good to me. However we should have an "integration" test target in AWSLambdaEvents that ensures that the examples in the runtime still compile after a change in events.

@fabianfett you mean in the new "events" repo, so that changes there dont break the runtime? could they?

@fabianfett
Copy link
Member

@fabianfett you mean in the new "events" repo, so that changes there dont break the runtime? could they?

The changes in there can't break the runtime, but the samples in the runtime repository, which would block CI.

@tomerd
Copy link
Contributor Author

tomerd commented Aug 13, 2021

The changes in there can't break the runtime, but the samples in the runtime repository, which would block CI.

it may ben easier (from a CI point of view) to add an example we can CI there as well. WDYT?

@tomerd
Copy link
Contributor Author

tomerd commented Aug 18, 2021

@fabianfett
Copy link
Member

fabianfett commented Aug 18, 2021

@tomerd Awesome! Now we should remove the APIGateway example from the code here. All other examples don't depend on AWSLambdaEvents. Maybe we should add to the soundness script that we never import AWSLambdaEvents except in markdown files :)

tomerd added 2 commits August 18, 2021 20:26
motivation: the runtime library has a stabel API while the events are still moving target, so in order to provide a 1.0 stable version we should separate them out

changes:
* remove Events module
* update readme
* update Samples
@tomerd
Copy link
Contributor Author

tomerd commented Aug 19, 2021

tomerd Awesome! Now we should remove the APIGateway example from the code here. All other examples don't depend on AWSLambdaEvents. Maybe we should add to the soundness script that we never import AWSLambdaEvents except in markdown files :)

done

@fabianfett
Copy link
Member

Failing nightly-main CI because of known issue in SwiftNIO: apple/swift-nio#1943 Not a blocker! Merging!

@fabianfett fabianfett merged commit 8525b63 into swift-server:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider abstracting event to separate repo so we can stabilize the core API
2 participants