async/await support #186

fabianfett · 2021-02-18T17:46:20Z

async/await is awesome! Let's support this in Lambda.

Modifications:

Add an AsyncLambdaHandler. Will be renamed to LambdaHandler as soon as we drop the current callback based LambdaHandler.
The default way to use an AsyncLambdaHandler is to use @main to execute it. Don't use Lambda.run for it. We wan't to remove Lambda.run for 1.0.

pokryfka · 2021-02-22T07:44:24Z

Node.js developers will feel at home :-)

But we would need swift-no support it to be useful inside Lambda handler implementations, no?

Seems to be in the pipeline :-)
apple/swift-nio#1701

fabianfett · 2021-02-25T16:33:35Z

This might be interesting to us. Potentially replacing the LambdaHandlerFactory:

swiftlang/swift#35398

weissi

Awesome, this looks great. Left a few comments, mostly minor around overloading / @asyncHandler etc

Sources/AWSLambdaRuntime/Lambda+Codable.swift

weissi · 2021-04-01T10:45:18Z

Sources/AWSLambdaRuntime/Lambda+Codable.swift

+    ///     - closure: `CodableVoidAsyncClosure` based Lambda.
+    ///
+    /// - note: This is a blocking operation that will run forever, as its lifecycle is managed by the AWS Lambda Runtime Engine.
+    public static func run<In: Decodable>(_ closure: @escaping CodableVoidAsyncClosure<In>) {


overloading on closure arguments is probably not a good idea

Sources/AWSLambdaRuntimeCore/Lambda.swift

Sources/AWSLambdaRuntimeCore/LambdaHandler.swift

weissi · 2021-04-01T10:54:28Z

Sources/AWSLambdaRuntimeCore/LambdaHandler.swift

+
+#if compiler(>=5.5) && $AsyncAwait
+/// Strongly typed, processing protocol for a Lambda that takes a user defined `In` and returns a user defined `Out` async.
+public protocol AsyncLambdaHandler: EventLoopLambdaHandler {


hmm, an AsyncLambdaHandler isn't running the async code on the EventLoop at the moment (that's impossible without custom executors), is this proto conformance still right?

Yes it is. Those protocols build up on top of each other:

ByteBufferLambdaHandler (just receive ByteBuffer on the EnventLoop)

EventLoopLambdaHandler (implements encoding and decoding to other types) - still on EventLoop

AsyncLambdaHandler - implements EventLoopLambdaHandler by dispatching of the EventLoop.

Sources/AWSLambdaRuntimeCore/LambdaHandler.swift

weissi · 2021-04-01T17:59:11Z

Package.swift

+
+#if compiler(>=5.5) && $AsyncAwait
+package.targets.first(where: { $0.name == "AWSLambdaRuntimeCore" })?
+    .dependencies.append(.product(name: "_NIOConcurrency", package: "swift-nio"))


you can always depend on it, _NIOConcurrency just doesn't export anything if A/A isn't on. But up to you

tomerd · 2021-04-01T20:49:16Z

Sources/AWSLambdaRuntime/Lambda+Codable.swift

@@ -78,6 +78,64 @@ internal struct CodableVoidClosureWrapper<In: Decodable>: LambdaHandler {
    }
 }

+// MARK: - Async
+
+#if compiler(>=5.5) && $AsyncAwait


this is good stuff. should we also mark the closure ones deprecated >= 5.5? I would argue we should.

Tests/AWSLambdaRuntimeCoreTests/LambdaHandlerTest.swift

fabianfett · 2021-04-17T20:12:56Z

Package.swift

@@ -15,7 +15,7 @@ let package = Package(
        .library(name: "AWSLambdaTesting", targets: ["AWSLambdaTesting"]),
    ],
    dependencies: [
-        .package(url: "https://github.com/apple/swift-nio.git", .upToNextMajor(from: "2.17.0")),
+        .package(url: "https://github.com/apple/swift-nio.git", .branch("main")),


We need to wait for the next NIO release before we can merge. @weissi ;)

Co-authored-by: tomer doron <tomerd@apple.com>

fabianfett · 2021-04-21T07:58:20Z

@swift-server-bot test this please

weissi

nice one! lgtm!

tomerd · 2021-04-27T19:56:52Z

awesome!

fabianfett force-pushed the async-await branch 4 times, most recently from d6b3b48 to 3f849a0 Compare April 1, 2021 10:11

fabianfett requested review from tomerd and weissi April 1, 2021 10:15

fabianfett marked this pull request as ready for review April 1, 2021 10:16

fabianfett changed the title ~~RFC: async/await support~~ async/await support Apr 1, 2021

weissi suggested changes Apr 1, 2021

View reviewed changes

fabianfett force-pushed the async-await branch 3 times, most recently from 2b6292d to b9e39fe Compare April 1, 2021 12:42

weissi reviewed Apr 1, 2021

View reviewed changes

fabianfett force-pushed the async-await branch from b9e39fe to daf16ef Compare April 1, 2021 18:57

tomerd reviewed Apr 1, 2021

View reviewed changes

fabianfett force-pushed the async-await branch from daf16ef to 8b3f630 Compare April 2, 2021 10:09

tomerd reviewed Apr 2, 2021

View reviewed changes

Tests/AWSLambdaRuntimeCoreTests/LambdaHandlerTest.swift Outdated Show resolved Hide resolved

tomerd reviewed Apr 2, 2021

View reviewed changes

Tests/AWSLambdaRuntimeCoreTests/LambdaHandlerTest.swift Outdated Show resolved Hide resolved

tomerd reviewed Apr 2, 2021

View reviewed changes

Tests/AWSLambdaRuntimeCoreTests/LambdaHandlerTest.swift Outdated Show resolved Hide resolved

tomerd reviewed Apr 2, 2021

View reviewed changes

Tests/AWSLambdaRuntimeCoreTests/LambdaHandlerTest.swift Outdated Show resolved Hide resolved

tomerd added this to the 1.0.0 milestone Apr 6, 2021

fabianfett force-pushed the async-await branch from 14d96bd to 5e05200 Compare April 17, 2021 20:03

fabianfett commented Apr 17, 2021

View reviewed changes

fabianfett force-pushed the async-await branch 2 times, most recently from 66b8fcc to 9e32a33 Compare April 17, 2021 20:27

fabianfett added 3 commits April 17, 2021 22:32

async/await support

6ad092b

Added simple tests

71d7805

Async Lambda initializer

e3b6b7c

fabianfett and others added 4 commits April 17, 2021 22:32

Update for Swift 5.5

469e7f8

Add AsyncLambdaHandler tests

0578764

PR review

d6f9d9a

Apply suggestions from code review

2b66aeb

Co-authored-by: tomer doron <tomerd@apple.com>

fabianfett force-pushed the async-await branch from 9e32a33 to 919d99a Compare April 17, 2021 20:34

async init and @main

325b7b3

fabianfett force-pushed the async-await branch from 919d99a to 325b7b3 Compare April 27, 2021 11:22

fabianfett requested review from tomerd and weissi April 27, 2021 11:23

weissi approved these changes Apr 27, 2021

View reviewed changes

tomerd approved these changes Apr 27, 2021

View reviewed changes

fabianfett merged commit 19fc295 into main Apr 27, 2021

fabianfett deleted the async-await branch April 27, 2021 20:47

tomerd modified the milestones: 1.0.0-alpha.1, 0.5.0 Jul 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

async/await support #186

async/await support #186

fabianfett commented Feb 18, 2021 •

edited

Loading

pokryfka commented Feb 22, 2021 •

edited

Loading

fabianfett commented Feb 25, 2021

weissi left a comment

weissi Apr 1, 2021

weissi Apr 1, 2021

fabianfett Apr 1, 2021 •

edited

Loading

weissi Apr 1, 2021

tomerd Apr 1, 2021 •

edited

Loading

fabianfett Apr 17, 2021

fabianfett commented Apr 21, 2021

weissi left a comment

tomerd commented Apr 27, 2021

async/await support #186

async/await support #186

Conversation

fabianfett commented Feb 18, 2021 • edited Loading

pokryfka commented Feb 22, 2021 • edited Loading

fabianfett commented Feb 25, 2021

weissi left a comment

Choose a reason for hiding this comment

weissi Apr 1, 2021

Choose a reason for hiding this comment

weissi Apr 1, 2021

Choose a reason for hiding this comment

fabianfett Apr 1, 2021 • edited Loading

Choose a reason for hiding this comment

weissi Apr 1, 2021

Choose a reason for hiding this comment

tomerd Apr 1, 2021 • edited Loading

Choose a reason for hiding this comment

fabianfett Apr 17, 2021

Choose a reason for hiding this comment

fabianfett commented Apr 21, 2021

weissi left a comment

Choose a reason for hiding this comment

tomerd commented Apr 27, 2021

fabianfett commented Feb 18, 2021 •

edited

Loading

pokryfka commented Feb 22, 2021 •

edited

Loading

fabianfett Apr 1, 2021 •

edited

Loading

tomerd Apr 1, 2021 •

edited

Loading