Fix event namespacing problems #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have potential name clashes with existing AWS libraries, if we namespace our events under the service name. For example `S3.Event`. This problem has been documented here: swift-server/swift-aws-lambda-runtime#119 ### Changes This PR picks up the fix, that was initially intended to land in the runtime repo directly: swift-server/swift-aws-lambda-runtime#203
|
@fabianfett looks good but sample needs to be fixed? |
|
@tomerd Sample pushed, but requires 5.5... |
|
@swift-server-bot test this please |
tomerd
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have potential name clashes with existing AWS libraries, if we namespace our events under the service name. For example
S3.Event. This problem has been documented here: swift-server/swift-aws-lambda-runtime#119Changes
This PR picks up the fix, that was initially intended to land in the runtime repo directly: swift-server/swift-aws-lambda-runtime#203
Result:
No more namespace issues with AWS libraries.