Skip to content

Bug/3658 add enzyme test for objectmodel #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

feenr
Copy link
Contributor

@feenr feenr commented Nov 6, 2017

Description

  • Add test to ensure that model properties are listed in the order specified in the schema
  • Add test to ensure that collapsible header is generated when rendering ObjectModel
  • Update CONTRIBUTING.md to specify the correct node version as a project pre-req

Motivation and Context

How Has This Been Tested?

  • Only test changes. Ensured all tests pass before submitting pull request.

Screenshots (if appropriate):

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Not sure if there's a code style document, but I followed the style of an existing test.

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@webron webron requested a review from shockey November 7, 2017 01:57
@shockey shockey merged commit 75d482f into swagger-api:master Nov 9, 2017
@shockey
Copy link
Contributor

shockey commented Nov 9, 2017

Merged!

Thanks for the PR, @feenr! Your test case looked great, I wouldn't have thought it was your first contribution if GitHub hadn't told me 😄

@feenr
Copy link
Contributor Author

feenr commented Nov 9, 2017 via email

@webron
Copy link
Contributor

webron commented Nov 9, 2017

@feenr Thanks for the offer! GitHub is a bit limited in that sense, so the best approach at the moment would indeed be adding a comment on a ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add enzyme test for <ObjectModel /> schema.properties rendering
3 participants