Form data monkey patch #1547
Merged
Form data monkey patch #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-lai
force-pushed
the
form-data-monkey-patch
branch
2 times, most recently
from
2d78112 to
986d14b
Compare
char0n
previously requested changes
May 20, 2020
tim-lai
force-pushed
the
form-data-monkey-patch
branch
from
986d14b to
62b1a36
Compare
* if form-data lib adds 'any' new method included in monkey patch, monkey patch will fail * update http-multipart tests for compatibility with form-data patch * live tests also refactored, remain in skip state * tested on node 8 Co-authored-by: Vladimir Gorej <vladimir.gorej@gmail.com> Co-authored-by: Timothy Lai <timothy.lai@gmail.com>
tim-lai
force-pushed
the
form-data-monkey-patch
branch
from
62b1a36 to
6c5a476
Compare
tim-lai
added a commit
to tim-lai/swagger-js
that referenced
this pull request
May 26, 2020
…api#1547) * if form-data lib adds 'any' new method included in monkey patch, monkey patch will fail * update http-multipart tests for compatibility with form-data patch * live tests also refactored, remain in skip state * tested on node 8 Co-authored-by: Vladimir Gorej <vladimir.gorej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
formdata-nodewith an internal patch ofform-data. Update tests to reflect dependency change.Motivation and Context
commit b35d36b introduced a dependency change from
form-datatoformdata-node. The reason was thatform-datais missing matching methods for FormData. However,formdata-nodealso required Node 10, which is technically a breaking semver change forswagger-client, but not noted as a breaking semver change in the release v3.10.3.We are choosing to maintain
swagger-clientin a non-breaking semver state. As a result, we are applying an internal patch toform-dataand removingformdata-node.Note: Node 8 has been EOL for some time now, and remains technically unsupported by
swagger-client.How Has This Been Tested?
Existing tests updated to reflect change between
formdata-nodeandform-data+ patchScreenshots (if appropriate):
Types of changes
package.json)Checklist: