Skip to content

Ticket 3469 #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ticket 3469 #3470

wants to merge 1 commit into from

Conversation

eak24
Copy link
Contributor

@eak24 eak24 commented Mar 12, 2020

Please see the explanation in the ticket: #3469 . I'm looking for help with

  • where should I put the test classes?
  • is there a more elegant way to compare the canonical names of the processedTypes and the incoming annotatedType?
  • is there any risk making the ModelConverterContextImpl part of the ModelResolvers singleton?

@eak24 eak24 force-pushed the ticket_3469 branch 2 times, most recently from cfd18dd to ca43c20 Compare March 18, 2020 02:04
@eak24
Keeps ModelConverterContextImpl in the ModelConverters singleton to a…
ce65ebb 
…void recreating and overwriting composedSchemas with normal schemas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eak24