You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
will return Generic type 'ListLogSummary' requires 1 type argument(s)
I understand that there is another interface with default type to use now, but it still was unpleasant surprise and not sure why default type could not be preserved while deprecating
The text was updated successfully, but these errors were encountered:
…f the new `LogResult`, the alias type should also support the default generic `DefaultLogFields` to allow downstream consumers to upgrade to newer `2.x` versions without the need to specify a generic.
Closes#586
Hi, thank you for pointing this out - there were no tests left using the deprecated interface which let this one slip through. The new version 2.35.2 on npm now re-introduces support for the ListLogSummary without a generic.
If you have any other problems using the library, please do open a new issue.
git-js/typings/response.d.ts
Line 305 in a054920
was left without default type for generic
git-js/typings/response.d.ts
Line 453 in d3e8dc7
Introduced in #533
removing default type for generic results in error for the client using this API, if it was used without specifying concrete type before deprecation
e.g.
will return
Generic type 'ListLogSummary' requires 1 type argument(s)
I understand that there is another interface with default type to use now, but it still was unpleasant surprise and not sure why default type could not be preserved while deprecating
The text was updated successfully, but these errors were encountered: