Skip to content

feat: add C implementation for math/base/special/coth #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: add C implementation for math/base/special/coth #1659

wants to merge 1 commit into from

Conversation

lovelindhoni
Copy link
Contributor

Resolves #754 .

Description

This pull request adds native C implementation for @stdlib/math/base/special/coth

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Pranavchiku Pranavchiku changed the title feat: add C implementation for @stdlib/math/base/special/coth feat: add C implementation for @stdlib/math/base/special/coth Mar 3, 2024
Pranavchiku
Pranavchiku suggested changes Mar 3, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lovelindhoni! Good direction, apply code review and this will be ready to merge.

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 3, 2024
@Pranavchiku Pranavchiku mentioned this pull request Mar 3, 2024
Closed
3 tasks
@lovelindhoni
Copy link
Contributor Author

@Pranavchiku, the requested changes have been made

@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/math/base/special/coth feat: add C implementation for math/base/special/coth Mar 3, 2024
@lovelindhoni lovelindhoni requested a review from Pranavchiku March 3, 2024 15:07
@lovelindhoni lovelindhoni mentioned this pull request Mar 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Awaiting requested review from Pranavchiku

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/coth
2 participants
@lovelindhoni @Pranavchiku