-
-
Notifications
You must be signed in to change notification settings - Fork 814
feat: add C implementation for math/base/special/round
#1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Pranavchiku Note that you previously worked on a PR for this feature: #745 |
@stdlib/math/base/special/round
math/base/special/round
Reference implementation: https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-math.round Not sure how much credible this source is, but aligns with other miscellaneous sources. |
@Pranavchiku That source is credible. That is the official ECMAScript specification from TC39. |
I think this is ready to review. |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, so let's get this in as the C implementation is required for the one of rempio2
, which @gunjjoshi will be working on soon.
Description
This PR adds C implementation for
@stdlib/math/base/special/round
Related Issues
Questions
Other
No.
Checklist
@stdlib-js/reviewers