Skip to content

feat: add C implementation for math/base/special/round #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2024

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Mar 2, 2024

Description

What is the purpose of this pull request?

This PR adds C implementation for @stdlib/math/base/special/round

Related Issues

Does this pull request have any related issues?

Questions

Any questions for reviewers of this pull request?

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Needs Discussion Needs further discussion. C Issue involves or relates to C. labels Mar 2, 2024
@Pranavchiku
Copy link
Member Author

cc @kgryte @Planeshifter

@kgryte
Copy link
Member

kgryte commented Mar 3, 2024

@Pranavchiku Note that you previously worked on a PR for this feature: #745

@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/math/base/special/round feat: add C implementation for math/base/special/round Mar 3, 2024
@Pranavchiku
Copy link
Member Author

Pranavchiku commented Mar 13, 2024

Reference implementation: https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-math.round

Not sure how much credible this source is, but aligns with other miscellaneous sources.

@Pranavchiku Pranavchiku added Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Mar 13, 2024
@kgryte
Copy link
Member

kgryte commented Mar 15, 2024

@Pranavchiku That source is credible. That is the official ECMAScript specification from TC39.

@Pranavchiku
Copy link
Member Author

I think this is ready to review.

@Pranavchiku Pranavchiku added Needs Review A pull request which needs code review. and removed Needs Discussion Needs further discussion. labels Mar 15, 2024
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, so let's get this in as the C implementation is required for the one of rempio2, which @gunjjoshi will be working on soon.

@Planeshifter Planeshifter merged commit 0227bf0 into stdlib-js:develop May 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Needs Review A pull request which needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants