Skip to content

Add unit tests for ParallelExecutor class in dspy.utils.parallelizer #8124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

SanjanShiv
Copy link
Contributor

This PR adds additional test cases for the ParallelExecutor:

  • Ensures worker threads maintain independence.
  • Validates parallel execution speed.
  • Tests error handling with max_errors.

All tests are passed locally.

Fixes: #8122

Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! looks solid, left some minor comments.

@SanjanShiv
Copy link
Contributor Author

Hey @chenmoneygithub, I've made all the necessary updates based on the feedback. When you get a chance, could you review it? Thanks!

Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenmoneygithub chenmoneygithub merged commit 4248c1e into stanfordnlp:main Apr 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit test for dspy.Parallel
2 participants