Ref System.Formats.Asn1 nuget package #1490
Conversation
|
Also delete ObjectIdentifier.cs? |
…rd2.1 Delete ObjectIdentifier.cs
scott-xu
requested review from
drieseng and
WojciechNagorski
as code owners
src/Renci.SshNet/Renci.SshNet.csproj
Outdated
| @@ -42,10 +42,10 @@ | |||
| <PackageReference Include="Nerdbank.GitVersioning" Version="3.7.70-alpha" PrivateAssets="all" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0' "> | |||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'netstandard2.1'"> | |||
There was a problem hiding this comment.
We don't want/need to reference Microsoft.Bcl.AsyncInterfaces for netstandard2.1. We should have:
net462 and netstandard2.0: AsyncInterfaces, Asn1, BouncyCastle
netstandard2.1: Asn1, BouncyCastle
netN.0: BouncyCastle
There was a problem hiding this comment.
Just out of curiosity, why Microsoft.Bcl.AsyncInterfaces targets netstandard2.1?
There was a problem hiding this comment.
So that it does not result in unnecessary transitive dependencies (like System.Threading.Tasks.Extensions). It is actually just a facade which forwards to the in-box types: https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Bcl.AsyncInterfaces/src/Microsoft.Bcl.AsyncInterfaces.csproj
There was a problem hiding this comment.
Yes, the Microsoft.Bcl.AsyncInterfaces for netstandard2.1 is just a facade, but System.Formats.Asn1 for net6.0+ contains all types which is confused.
# Conflicts: # src/Renci.SshNet/Renci.SshNet.csproj
This PR references System.Formats.Asn1 instead of using home-made
DerDataclass.I'm trying to add PKCS#8 support after this PR. See RFC5208
Contributes to #1090