Skip to content

Delete dead code #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Delete dead code #1140

wants to merge 1 commit into from

Conversation

Rob-Hague
Copy link
Collaborator

Only internal stuff. That was fun.

@Rob-Hague Rob-Hague requested a review from drieseng as a code owner June 5, 2023 09:40
@drieseng
Copy link
Member

drieseng commented Jun 6, 2023

@Rob-Hague, this only concerns code that we imported from other OSS projects. Updating this code may not be a good idea (or even allowed), as it makes it harder to diff new drops of this code in the future.

@WojciechNagorski, what's your opinion on this?

@WojciechNagorski
Copy link
Collaborator

@Rob-Hague Thanks for your work but if this code is imported from an OSS project, we should not remove or modify it.

@Rob-Hague
Copy link
Collaborator Author

Fair enough, perhaps it is worth considering instead taking a dependency on the BouncyCastle nuget package, now that there is one.

@Rob-Hague
Copy link
Collaborator Author

@WojciechNagorski have you got a rough plan or list of priorities in mind for the repo? I would like to help where I can.

I would think something like:

  1. Test infrastructure
  2. Support rsa-sha2 key host algorithms
  3. Publish a new release
  4. ???

@WojciechNagorski
Copy link
Collaborator

@Rob-Hague Hi, For now, I have to move all integration tests (from https://github.com/sshnet/IntegrationTests and from unit tests) to the new integration project. Then publish a new release. After that, we can think about RSA-SHA2.

@WojciechNagorski
Copy link
Collaborator

@Rob-Hague If you want to help me, you can contact me by e-mail.

@Rob-Hague Rob-Hague mentioned this pull request Dec 10, 2023
@Rob-Hague Rob-Hague deleted the deadcode branch July 24, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants