Skip to content

SOCKS5: Support domain name address type #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
reang opened this issue Oct 8, 2016 · 1 comment
Closed

SOCKS5: Support domain name address type #98

reang opened this issue Oct 8, 2016 · 1 comment
Assignees
@drieseng
Labels
bug
Milestone
2016.1.0-beta1

Comments

@reang
Copy link

reang commented Oct 8, 2016

Hi, anyone can resolve this error?
Error
@drieseng drieseng changed the title An invalid IP address was specified SOCKS5: Support domain name address type Oct 9, 2016
@drieseng drieseng self-assigned this Oct 9, 2016
@drieseng
Copy link
Member

drieseng commented Oct 16, 2016 •
edited
Loading

I'm working on this.

Not sure if we should just pass the domain name to the SSH server, or if we should also have an option to resolve the host name locally. We could just say that this is an option the SOCKS client should offer, and not the SOCKS proxy (meaning SSH.NET).

drieseng added a commit that referenced this issue Nov 3, 2016
@drieseng
Added support domain name address type for SOCKS5.
13fff36 
Fixes issue #98.
@drieseng drieseng closed this as completed Nov 3, 2016
@drieseng drieseng added this to the 2016.1.0 milestone Nov 3, 2016
@drieseng drieseng modified the milestones: 2016.1.0-beta1, 2016.1.0 Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drieseng drieseng

Labels
bug
Projects
None yet
Milestone
2016.1.0-beta1
Development

No branches or pull requests
2 participants
@reang @drieseng