Skip to content

Fix two line wrapping bugs in default report formatter #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

anomiex
Copy link

@anomiex anomiex commented Nov 14, 2023

Description

The first is that the ANSI escape codes applied to bold the message when -s is used were not being taken into account when wrapping the lines for width, causing some lines to be wrapped unnecessarily.

The second is that when lines were wrapped in the middle of a long message, the | characters making up the table were being bolded along with the message.

Suggested changelog entry

  • Avoid unnecessarily wrapping lines in the full report when -s is used.
  • Fix incorrect bolding of pipes in the full report tables when -s is used and messages wrap.

Related issues/external references

Fixes #3924

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
    • I see no existing tests for any of the reporting formats.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.
  • [Required for new files] I have added any new files to the package.xml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary line wrapping with -s
1 participant