Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw exception when specified ldif file does not exist #8434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw exception when specified ldif file does not exist #8434
Changes from 3 commits
753a927
4a6b497
ab67520
075458b
921fbab
10d3492
8db1207
2a8c5dd
c99b252
9fac54f
7429f9e
bc8e099
23ac382
179a466
e4c9d81
0efb886
1fa8a4b
479d2bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An
IllegalArgumentException
is more suitable in this case.LDAPException
should only be used when a problem occurs while performing LDAP-related processing.In this case, we haven't started the LDAP-related processing yet, so we should use
IllegalArgumentException
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
InMemoryDirectoryServer
throwLDAPException
I can wrap it but I think it's not a good practice.public InMemoryDirectoryServer(final String... baseDNs) throws LDAPException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for the original issue.
The test should create an
UnboundIdContainer
with an LDIF that does not exist, and ensure that an exception is thrown.