Fix Documentation to Refer to BasicAuthenticationFilter #8414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
eleftherias
suggested changes
Apr 20, 2020
There was a problem hiding this comment.
Thanks for the PR @dadikovi!
I have one change request, which is to add Fixes gh-8119 as part of the commit message.
This will associate the commit with the reported issue and also close the issue when the commit is merged.
See the contributing guidelines for more details.
eleftherias
added
in: docs
|
Thank you, I modified the commit message :) |
eleftherias
suggested changes
Apr 20, 2020
There was a problem hiding this comment.
Thanks for the quick response @dadikovi!
Our convention is the have the "Fixes gh-..." message on a new line.
Could you please update you commit message to have that structure?
It would look like this
Document description error
Fixes gh-8119
|
Oh, I'm sorry :S |
|
Thanks for the PR @dadikovi! |
rwinch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a small modification on the documentation, which fixes gh-8119.
I have submitted the CLA.