Skip to content

Rename Preface to Introduction #8411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

Rename Preface to Introduction #8411

merged 1 commit into from
Apr 20, 2020

Conversation

corneliouzbett
Copy link
Contributor

Renamed Preface Section of docs to Introduction

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 17, 2020
@rwinch
Copy link
Member

rwinch commented Apr 17, 2020

Thanks for PR! Can you please update your commit message to align for contributor guidelines https://github.com/spring-projects/spring-security/blob/master/CONTRIBUTING.adoc#format-commit-messages

Something like this works:

Rename Preface to Introduction

Closes gh-8188

@rwinch rwinch added the in: docs An issue in Documentation or samples label Apr 17, 2020
@rwinch rwinch self-assigned this Apr 17, 2020
@corneliouzbett corneliouzbett changed the title gh-8188: Rename Preface Section of docs to Introduction Rename Preface to Introduction Apr 17, 2020
@corneliouzbett
Copy link
Contributor Author

corneliouzbett commented Apr 17, 2020 •
edited
Loading

Thanks for PR! Can you please update your commit message to align for contributor guidelines https://github.com/spring-projects/spring-security/blob/master/CONTRIBUTING.adoc#format-commit-messages

Something like this works:

Rename Preface to Introduction

Closes gh-8188

Thanks for the review! @rwinch Just updated the PR to reflect your changes

@rwinch rwinch added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 20, 2020
@rwinch rwinch mentioned this pull request Apr 20, 2020
Closed
@rwinch rwinch added this to the 5.4.0.M1 milestone Apr 20, 2020
@rwinch rwinch merged commit ebc6012 into spring-projects:master Apr 20, 2020
@rwinch
Copy link
Member

rwinch commented Apr 20, 2020

Thanks for the Pull Request! This is now merged into master 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@corneliouzbett @rwinch @spring-projects-issues