Add constructors receiving AuthenticationManager #8362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
changed the title
rwinch
requested changes
Apr 9, 2020
There was a problem hiding this comment.
Thanks for the PR! I've added some comments inline. Additionally, can you please fix the commit format to match our conventions. Something like:
Add constructors receiving AuthenticationManager
Closes gh-8309
Please also add tests for each of the constructors that were created.
| @@ -357,6 +394,7 @@ protected AuthenticationManager getAuthenticationManager() { | |||
| } | |||
|
|
|||
| public void setAuthenticationManager(AuthenticationManager authenticationManager) { | |||
| Assert.notNull(authenticationManager, "authenticationManager cannot be null"); | |||
There was a problem hiding this comment.
This is not really making any guarantees since the value is possibly null before, so we don't do an assertion here.
| @@ -63,6 +64,10 @@ public UsernamePasswordAuthenticationFilter() { | |||
| super(new AntPathRequestMatcher("/login", "POST")); | |||
| } | |||
|
|
|||
| public UsernamePasswordAuthenticationFilter(AuthenticationManager authenticationManager) { | |||
| super(new AntPathRequestMatcher("/login", "POST"), authenticationManager); | |||
There was a problem hiding this comment.
Let's extract the default request matcher into a a static variable to ensure consistency throughout the constructors.
|
Thanks for fast response. I went ahead and squashed your commit and updated the commit message. Your changes were merged into master in b7d3acc |
rwinch
added
in: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-8309