Skip to content

Added setPrincipalClaimName to JwtAuthenticationConverter #8318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

Added setPrincipalClaimName to JwtAuthenticationConverter #8318

merged 1 commit into from
Apr 7, 2020

Conversation

evgeniycheban
Copy link
Contributor

Fixes gh-8186

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 3, 2020
jzheaux
jzheaux requested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evgeniycheban, for your contribution! I've left some feedback inline.

Also, once these changes are applied, will you please squash your commits, in preparation for merging?

@evgeniycheban evgeniycheban requested a review from jzheaux April 7, 2020 16:13
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 7, 2020
@jzheaux jzheaux added this to the 5.4.0.M1 milestone Apr 7, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Apr 7, 2020

Thanks, @evgeniycheban! This is new merged into master.

@jzheaux jzheaux closed this Apr 7, 2020
@jzheaux jzheaux reopened this Apr 7, 2020
@jzheaux jzheaux merged commit 25fb1f4 into spring-projects:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M1
Development

Successfully merging this pull request may close these issues.

JwtAuthenticationConverter should allow for configuring the principal claim
3 participants
@evgeniycheban @jzheaux @spring-projects-issues