Skip to content

OAuth2LoginAuthenticationProvider uses OAuth2AuthorizationCodeAuthenticationProvider #8170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

OAuth2LoginAuthenticationProvider uses OAuth2AuthorizationCodeAuthenticationProvider #8170

wants to merge 1 commit into from

Conversation

rh-id
Copy link
Contributor

@rh-id rh-id commented Mar 22, 2020

  1. update OAuth2LoginAuthenticationProvider to use
    OAuth2AuthorizationCodeAuthenticationProvider class

  2. update OAuth2LoginAuthenticationToken to extends
    OAuth2AuthorizationCodeAuthenticationToken

  3. apply fix Add additional parameters to OAuth2UserRequest #5368 for OAuth2AuthorizationCodeAuthenticationProvider
    to return additionalParameters value from accessTokenResponse

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 22, 2020
@rh-id rh-id mentioned this pull request Mar 22, 2020
Closed
@rwinch rwinch assigned rwinch and jgrandja and unassigned rwinch Mar 24, 2020
@rwinch rwinch changed the title Fixes gh-5633 : refactor OAuth2LoginAuthenticationProvider OAuth2LoginAuthenticationProvider uses OAuth2AuthorizationCodeAuthenticationProvider Mar 24, 2020
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 24, 2020
@jgrandja jgrandja added this to the 5.1.x milestone Mar 24, 2020
jgrandja
jgrandja requested changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rh-id ! Please see my comments.

@jgrandja jgrandja mentioned this pull request Mar 24, 2020
Closed
@rh-id rh-id requested a review from jgrandja March 25, 2020 06:30
@jgrandja
Copy link
Contributor

@rh-id This looks great! One last thing before we merge. Can you squash the 2 commits to 1 and ensure the commit message follows this format.

@rh-id
refactor OAuth2LoginAuthenticationProvider
7b904da 
1. update OAuth2LoginAuthenticationProvider to use
OAuth2AuthorizationCodeAuthenticationProvider
2. apply fix gh-5368 for OAuth2AuthorizationCodeAuthenticationProvider
to return additionalParameters value from accessTokenResponse

Fixes gh-5633
@jgrandja jgrandja removed this from the 5.1.x milestone Mar 31, 2020
@jgrandja jgrandja added the status: duplicate A duplicate of another issue label Mar 31, 2020
@jgrandja
Copy link
Contributor

Thank you for the PR @rh-id ! This is now in master and backported to 5.1.x.

@jgrandja jgrandja closed this Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandja jgrandja Awaiting requested review from jgrandja

Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add additional parameters to OAuth2UserRequest
4 participants
@rh-id @jgrandja @rwinch @spring-projects-issues