Skip to content

SAML AuthNRequest Signatures - Step 2 #7759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fhanik
Copy link
Contributor

@fhanik fhanik commented Dec 20, 2019

Provides an implementation for POST BINDING for AuthNRequest messages.

Has been tested with

  • Keycloak
  • SSOCircle
  • Okta
  • SimpleSAMLPhp

This PR extends (builds on previous commits and adds user configuration options)
#7758

@fhanik fhanik force-pushed the feature/authn_request_signatures branch 2 times, most recently from 683426f to 068679f Compare January 2, 2020 21:42
@fhanik fhanik self-assigned this Jan 2, 2020
@fhanik fhanik added the in: saml2 An issue in SAML2 modules label Jan 2, 2020
@fhanik fhanik added this to the 5.3.0.RC1 milestone Jan 2, 2020
@fhanik fhanik changed the title SAML AuthNRequest Signatures - Option 2 SAML AuthNRequest Signatures - Step 2 Jan 10, 2020
@eleftherias eleftherias modified the milestones: 5.3.0.RC1, 5.3.0 Feb 5, 2020
fhanik added a commit to fhanik/spring-security that referenced this pull request Feb 11, 2020
…equest is signed

Has been tested with
- Keycloak
- SSOCircle
- Okta
- SimpleSAMLPhp

Further configuration options (POST vs REDIRECT) that build on top of
this PR can be found in:
spring-projects#7759

[fixes spring-projects#7711]
@fhanik fhanik force-pushed the feature/authn_request_signatures branch from aa9cca6 to 6bdd5dd Compare February 12, 2020 23:36
@fhanik fhanik requested a review from jzheaux February 12, 2020 23:40
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fhanik! I've left some feedback.

@jzheaux jzheaux added status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: duplicate A duplicate of another issue labels Feb 27, 2020
@fhanik fhanik force-pushed the feature/authn_request_signatures branch from 6bdd5dd to e11e800 Compare February 27, 2020 20:10
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've left a bit more feedback.

Has been tested with

- Keycloak
- SSOCircle
- Okta
- SimpleSAMLPhp

This PR extends (builds on previous commits and adds user configuration
options)
spring-projects#7758
@fhanik fhanik force-pushed the feature/authn_request_signatures branch from c7937d1 to f460ea5 Compare February 28, 2020 16:26
@fhanik fhanik merged commit 3257349 into spring-projects:master Feb 28, 2020
@fhanik fhanik deleted the feature/authn_request_signatures branch February 28, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants