Skip to content

Specify return type in InitializeUserDetailsBeanManagerConfigurer method Javadoc #7557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

Specify return type in InitializeUserDetailsBeanManagerConfigurer method Javadoc #7557

merged 1 commit into from
Nov 13, 2019

Conversation

rastadrian
Copy link
Contributor

When the AuthenticationConfiguration sets the UserDetailsBeanConfigurer it creates a DaoAuthenticationProvider without the capabilities of setting an ApplicationContext registered UserCache bean.

Fixes gh-7556

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 23, 2019
@jzheaux jzheaux requested a review from rwinch October 30, 2019 20:22
@eleftherias
Copy link
Contributor

Thanks for the PR @rastadrian.
Given what was mentioned in the issue gh-7556, about only focusing on the most frequently used beans for automatic detection, we do not want to set the user cache on the provider.
I noticed that you also made an enhancement to the Javadoc in the InitializeUserDetailsBeanManagerConfigurer class. We can merge the Javadoc change if you want to update your PR to only include that line.

@eleftherias eleftherias added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 12, 2019
@rastadrian rastadrian force-pushed the dao-auth-provider-user-cache branch from 32c50b1 to 831443c Compare November 13, 2019 03:38
@rastadrian
Copy link
Contributor Author

Hi @eleftherias, I have updated the PR to only include the javadoc change.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Nov 13, 2019
@eleftherias eleftherias merged commit ca8877c into spring-projects:master Nov 13, 2019
@eleftherias
Copy link
Contributor

Thanks for the speedy update @rastadrian! This is now merged into master.

@eleftherias eleftherias added in: docs An issue in Documentation or samples and removed status: feedback-provided Feedback has been provided labels Nov 13, 2019
@eleftherias eleftherias self-assigned this Nov 13, 2019
@eleftherias eleftherias added the type: enhancement A general enhancement label Dec 12, 2019
@eleftherias eleftherias added this to the 5.3.0.M1 milestone Dec 12, 2019
@eleftherias eleftherias changed the title Adds UserCache to the DaoAuthenticationprovider through AuthenticationConfiguration Specify return type in InitializeUserDetailsBeanManagerConfigurer method Javadoc Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinch rwinch Awaiting requested review from rwinch

Assignees

@eleftherias eleftherias

Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.0.M1
Development

Successfully merging this pull request may close these issues.

UserCache in DaoAuthenticationProvider Auto Configuration
3 participants
@rastadrian @eleftherias @spring-projects-issues