Polish Server|ServletBearerExchangeFilterFunction #7355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzheaux
added
in: oauth2
jgrandja
requested changes
Sep 4, 2019
.../oauth2/server/resource/web/reactive/function/client/ServerBearerExchangeFilterFunction.java
Show resolved
Hide resolved
| implements ExchangeFilterFunction { | ||
|
|
||
| private static final String AUTHENTICATION_ATTR_NAME = Authentication.class.getName(); | ||
|
|
||
| private static final AnonymousAuthenticationToken ANONYMOUS_USER_TOKEN = new AnonymousAuthenticationToken("anonymous", "anonymousUser", |
There was a problem hiding this comment.
This is not needed please remove
.../oauth2/server/resource/web/reactive/function/client/ServerBearerExchangeFilterFunction.java
Show resolved
Hide resolved
...oauth2/server/resource/web/reactive/function/client/ServletBearerExchangeFilterFunction.java
Outdated
Show resolved
Hide resolved
| public final class ServletBearerExchangeFilterFunction | ||
| implements ExchangeFilterFunction { | ||
|
|
||
| private static final AnonymousAuthenticationToken ANONYMOUS_USER_TOKEN = new AnonymousAuthenticationToken("anonymous", "anonymousUser", |
There was a problem hiding this comment.
Please remove as it's not needed
There was a problem hiding this comment.
It's used on line 91. Are you proposing a change to currentAuthentication()
There was a problem hiding this comment.
Yes just return Mono.empty()
...oauth2/server/resource/web/reactive/function/client/ServletBearerExchangeFilterFunction.java
Show resolved
Hide resolved
jgrandja
approved these changes
Sep 4, 2019
|
Thanks again, @jgrandja, big improvement here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-7353