Skip to content

Remove Servlet 2.5 and 3.0 Support for Remember Me and CSRF #6278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2018
Merged

Remove Servlet 2.5 and 3.0 Support for Remember Me and CSRF #6278

merged 1 commit into from
Dec 14, 2018

Conversation

dongmyo
Copy link
Contributor

@dongmyo dongmyo commented Dec 12, 2018 •
edited
Loading

Remove Servlet 2.5 and 3.0 Support for Remember Me and CSRF

Fixes: gh-6263, Fixes: gh-6262

@jzheaux
Copy link
Contributor

jzheaux commented Dec 12, 2018

@dongmyo Thanks for the PR. Would you do me the favor of changing your commit title and message to include #6262 as well?

@dongmyo dongmyo changed the title Remove Servlet 2.5 and 3.0 Support for Remember Me Remove Servlet 2.5 and 3.0 Support for Remember Me and CSRF Dec 13, 2018
@dongmyo
Copy link
Contributor Author

dongmyo commented Dec 13, 2018

@jzheaux i changed the commit message.

@jzheaux
Copy link
Contributor

jzheaux commented Dec 13, 2018

Now that #6276 is merged, @dongmyo, will you please do a quick rebase before we merge this one?

@dongmyo
Copy link
Contributor Author

dongmyo commented Dec 13, 2018

@jzheaux i rebased

jzheaux
jzheaux requested changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongmyo Looking at this just a bit more carefully I think there is one more reference to Servlet 3.0 remaining in AbstractRememberMeServices.

@jzheaux jzheaux merged commit fc802e1 into spring-projects:master Dec 14, 2018
@jzheaux
Copy link
Contributor

jzheaux commented Dec 14, 2018

Thanks again, @dongmyo! This is now merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Servlet 2.5 and 3.0 Support for Remember Me Remove Servlet Spec 2.5 and 3.0 Support for CSRF
2 participants
@dongmyo @jzheaux