Skip to content

Use Test<Object>s naming convention for WebAuthn test object factories #16865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vasanth-79
Copy link
Contributor

@vasanth-79 vasanth-79 commented Apr 2, 2025

Issue Number: 16604

Renamed the WebAuthn Test Object class names.

Refactored class names to follow pluralized naming pattern.
Updated all instances in the codebase where these class names were used to ensure consistency.
Updated related references in the code to match the new class names.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 2, 2025
Renamed the WebAuthn Test Object class names

Signed-off-by: Vasanth <76898064+vasanth-79@users.noreply.github.com>
@jzheaux
Copy link
Contributor

jzheaux commented Apr 3, 2025

Thank you, @vasanth-79! This is now merged into main. I hope to see more contributions from you in the future! Please look for the status: ideal-for-contribution label on tickets.

Also, and this is just a minor thing, you might notice that this PR says "closed" instead of "merged". It was indeed merged in 04d7130 and 4cdc6da; however, I couldn't push these polishes to the PR since it was from your main branch. For future PRs, you can cut a branch, like gh-16604 and that makes it possible for me to push the polishes to that branch and we merge the PR from here.

@jzheaux jzheaux closed this Apr 3, 2025
@jzheaux jzheaux self-assigned this Apr 3, 2025
@jzheaux jzheaux added this to the 6.5.0-RC1 milestone Apr 3, 2025
@jzheaux jzheaux added the type: enhancement A general enhancement label Apr 3, 2025
@jzheaux jzheaux changed the title Update WebAuthn Test Objects Class Names #16604 Use Test<Object>s naming convention for WebAuthn test object factories Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants