Skip to content

webauthn js should ensure allowCredentials[].id is an ArrayBuffer #16440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Kehrlann
Copy link
Contributor

closes gh-16439

@Kehrlann Kehrlann force-pushed the fix/webauthn-authentication-allowed-credentials branch from 3e8f36d to 43d2710 Compare January 17, 2025 14:09
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 17, 2025
closes spring-projectsgh-16439

Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
@Kehrlann Kehrlann force-pushed the fix/webauthn-authentication-allowed-credentials branch from 43d2710 to 5bf42bb Compare January 17, 2025 14:14
@Kehrlann Kehrlann changed the base branch from main to 6.4.x January 17, 2025 14:16
@rwinch rwinch changed the title webauthn: ensure allowCredentials[].id is an ArrayBuffer webauthn js should ensure allowCredentials[].id is an ArrayBuffer Jan 17, 2025
@rwinch rwinch merged commit 5bf42bb into spring-projects:6.4.x Jan 17, 2025
6 checks passed
@rwinch rwinch self-assigned this Jan 17, 2025
@rwinch rwinch added in: web An issue in web modules (web, webmvc) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 17, 2025
@rwinch rwinch added this to the 6.4.3 milestone Jan 17, 2025
@rwinch
Copy link
Member

rwinch commented Jan 17, 2025

Thanks for the Pull Request! This is now merged into 6.4.x and main 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebAuthn login fails when CredentialsRequestOptions.publicKey.allowCredentials is not empty
3 participants