Skip to content

Fix malformed list in "Using Method Parameters" documentation #15325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix malformed list in "Using Method Parameters" documentation #15325

merged 1 commit into from
Jul 1, 2024

Conversation

Marcono1234
Copy link
Contributor

See section "Using Method Parameters" in the current documentation. It looks like it is supposed to list the order in which Spring tries to discover parameter names:

  1. @P
  2. @Param
  3. javac -parameters
  4. javac with debug symbols

However, currently it is erroneously displayed as:

  1. @P
    • @Param
    • javac -parameters
    • javac with debug symbols

This pull request tries to fix this.

Though please let me know if I misunderstood this, or if there is a better way to solve this.

@pivotal-cla
Copy link

@Marcono1234 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@Marcono1234
Copy link
Contributor Author

@pivotal-cla This is an Obvious Fix

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 30, 2024
@pivotal-cla
Copy link

@Marcono1234 This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@jzheaux jzheaux added type: bug A general bug in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 1, 2024
@jzheaux jzheaux merged commit a9aefaf into spring-projects:main Jul 1, 2024
4 checks passed
@jzheaux jzheaux self-assigned this Jul 1, 2024
@jzheaux jzheaux added this to the 6.4.0-M1 milestone Jul 1, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Jul 1, 2024

Thanks, @Marcono1234! This is now merged into main.

@Marcono1234 Marcono1234 deleted the method-params-doc-list branch July 7, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants