Closes #13754 Add hasScope and hasAnyScope for authorization rules #13769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
reviewed
Sep 12, 2023
There was a problem hiding this comment.
Thanks, @petrovskimario! I've left some feedback inline.
Also, even though the functionality here is straightforward, will you please add a Tests class that confirms they work as expected? That way they can be changed in the future with confidence.
...src/main/java/org/springframework/security/oauth2/core/ScopeAuthorizationManagerFactory.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/security/oauth2/core/ScopeAuthorizationManagerFactory.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/security/oauth2/core/ScopeAuthorizationManagerFactory.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/security/oauth2/core/ScopeAuthorizationManagerFactory.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/security/oauth2/core/ScopeAuthorizationManagerFactory.java
Outdated
Show resolved
Hide resolved
|
Hello @jzheaux Thank you for your suggestions. Please review and let me know if something can be improved. |
|
Thanks, @petrovskimario! This is now merged into |
jzheaux
added
status: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.