Add functionality to set custom web client in ReactiveOidcIdTokenDecoderFactory #13301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ubaid4j Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ubaid4j Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
mshmmarszelewski
approved these changes
Jun 13, 2023
jzheaux
requested changes
Jul 3, 2023
...gframework/security/oauth2/client/oidc/authentication/ReactiveOidcIdTokenDecoderFactory.java
Outdated
Show resolved
Hide resolved
...gframework/security/oauth2/client/oidc/authentication/ReactiveOidcIdTokenDecoderFactory.java
Outdated
Show resolved
Hide resolved
...gframework/security/oauth2/client/oidc/authentication/ReactiveOidcIdTokenDecoderFactory.java
Outdated
Show resolved
Hide resolved
|
@jzheaux could you revisit this PR once again please? |
jzheaux
added
type: enhancement
jzheaux
approved these changes
Feb 1, 2024
jzheaux
added
status: duplicate
|
It looks like this was already done and I missed that: #14357 However, given the work you put in, I think what I'd like to do is still merge the part of this PR that adds your author tag to the two classes. Thanks for your contribution! |
jzheaux
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see gh-13274
Thanks