Skip to content

Saml2WebSsoAuthenticationRequesFilter should be post-processed #8552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzheaux opened this issue May 18, 2020 · 0 comments
Closed

Saml2WebSsoAuthenticationRequesFilter should be post-processed #8552

jzheaux opened this issue May 18, 2020 · 0 comments
Assignees
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented May 18, 2020

It should be possible to use an ObjectPostProcessor to post-process the configuration of Saml2WebSsoAuthenticationRequestFilter.

Otherwise, there is no clear way to configure its RequestMatcher or its Saml2AuthenticationRequestContextResolver other than to bypass saml2Login on the DSL and instantiate the filter itself.

For additional context, note that OAuth2LoginConfigurer post-processes its equivalent filter, OAuth2AuthorizationRequestRedirectFilter.

@jzheaux jzheaux added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels May 18, 2020
@jzheaux jzheaux added this to the 5.4.0-M2 milestone May 18, 2020
@jzheaux jzheaux self-assigned this May 18, 2020
jzheaux added a commit that referenced this issue May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant