Skip to content

Consider adding JwtClaimValidator #7860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Jan 24, 2020 · 2 comments
Closed

Consider adding JwtClaimValidator #7860

jzheaux opened this issue Jan 24, 2020 · 2 comments
Assignees
@jzheaux
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.3.0

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jan 24, 2020

JwtClaimValidator could be a nice generalization of JwtIssuerValidator. Something like:

public JwtClaimValidator(String claim, Predicate<T> test)

Where claim is the name of the claim to validate, test is the test to perform, and T is the claim value's type.
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement labels Jan 24, 2020
@zeeshanadnan
Copy link
Contributor

If no one is working on it i would like to work on it.

@jzheaux
Copy link
Contributor Author

jzheaux commented Feb 7, 2020

@zeeshanadnan sounds great! It's yours.

@jzheaux jzheaux self-assigned this Feb 7, 2020
@zeeshanadnan zeeshanadnan mentioned this issue Feb 9, 2020
Closed
zeeshanadnan added a commit to zeeshanadnan/spring-security that referenced this issue Feb 22, 2020
@zeeshanadnan
Add JwtClaimValidator
02d03ed 
fixes spring-projectsgh-7860
jzheaux added a commit that referenced this issue Feb 25, 2020
@jzheaux
Update JwtDecoders tests
283e451 
Issue gh-7860
@jzheaux jzheaux added this to the 5.3.0 milestone Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

Add JwtClaimValidator zeeshanadnan/spring-security
2 participants
@jzheaux @zeeshanadnan