Skip to content

throws Exception was removed from WebSecurityConfigurerAdapter#configure(WebSecurity) #7541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MasatoshiTada opened this issue Oct 18, 2019 · 1 comment · Fixed by #7580
Closed

throws Exception was removed from WebSecurityConfigurerAdapter#configure(WebSecurity) #7541

MasatoshiTada opened this issue Oct 18, 2019 · 1 comment · Fixed by #7580
Assignees
@jzheaux
Labels
in: config An issue in spring-security-config type: bug A general bug
Milestone
5.2.1

Comments

@MasatoshiTada
Copy link

MasatoshiTada commented Oct 18, 2019 •
edited
Loading

Summary

throws Exception was removed from WebSecurityConfigurerAdapter#configure(WebSecurity) with the commit below.

34dd5fe#diff-5cc9a70efb559a4a15966c3b7215538c

I understand this is redundant, but when we upgrade from 5.1.x to 5.2.0.RELEASE, this occurs compilation error in subclasses of WebSecurityConfigurerAdapter in our application codes.

Expected Behavior

throws Exception should not be removed, or it should be written in Release Notes as the incompatibility.

Version

spring-security-config 5.2.0.RELEASE
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 18, 2019
@jzheaux jzheaux self-assigned this Oct 28, 2019
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug in: web An issue in web modules (web, webmvc) and removed status: waiting-for-triage An issue we've not yet triaged in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Oct 28, 2019
@jzheaux jzheaux added this to the 5.2.x milestone Oct 28, 2019
jzheaux added a commit to jzheaux/spring-security that referenced this issue Oct 29, 2019
@jzheaux
Restore Removed Throws Clauses
a6726c0 
In a recent clean-up, certain exceptions were removed from various
throws clauses.

This PR re-introduces throws clauses that are important for one of the
following reasons:

1. It's a method on a public interface
2. It's a method clearly designed for inheritance, for example, a
method stub, an abstract method, or indicated as such in the docs.

Fixes spring-projectsgh-7541
@jzheaux jzheaux mentioned this issue Oct 29, 2019
Merged
@jzheaux jzheaux added in: config An issue in spring-security-config and removed in: web An issue in web modules (web, webmvc) labels Oct 29, 2019
@jzheaux jzheaux modified the milestones: 5.2.x, 5.2.1 Oct 29, 2019
jzheaux added a commit that referenced this issue Oct 30, 2019
@jzheaux
Restore Removed Throws Clauses
5f17032 
In a recent clean-up, certain exceptions were removed from various
throws clauses.

This PR re-introduces throws clauses that are important for one of the
following reasons:

1. It's a method on a public interface
2. It's a method clearly designed for inheritance, for example, a
method stub, an abstract method, or indicated as such in the docs.

Fixes gh-7541
@MasatoshiTada
Copy link
Author

Amazing! Thank you for your quick fixing!😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config type: bug A general bug
Projects
None yet
Milestone
5.2.1
Development

Successfully merging a pull request may close this issue.

Restore Removed Throws Clauses jzheaux/spring-security
3 participants
@jzheaux @MasatoshiTada @spring-projects-issues