Add unit tests to oauth2-core

[jgrandja]

Summary

Unit tests need to be added to the oauth2-core module.

[luander]

What is the expected behavior when the following code is called:

AuthorizationCodeTokenRequestAttributes
	.withCode("code")
//	.clientId(null)
	.redirectUri("http://redirect.uri/")
	.build();

Does it let the object be created without the clientId or should it fail with IllegalArgumentException?

[jgrandja]

@luander The build() method should throw IllegalArgumentException given that clientId is a required attribute as per spec.

[luander]

Thanks for the answer Joe. I was writing the tests for this and other classes and noticed the current behavior is not correct.

[jgrandja]

@Launder Yes, the current behaviour is not correct hence the need for unit tests. Thanks for taking this on!

FYI, our current naming scheme for test methods is as follows:

methodNameWhen<Condition>Then<Expectation>

You can see examples of this in the following test classes:

AuthorizationCodeAuthenticationProcessingFilterTests
AuthorizationCodeRequestRedirectFilterTests