Skip to content

Configuration examples in docs are out of date #14384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjohnr opened this issue Dec 28, 2023 · 4 comments
Closed

Configuration examples in docs are out of date #14384

sjohnr opened this issue Dec 28, 2023 · 4 comments
Assignees
Labels
in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: enhancement A general enhancement
Milestone

Comments

@sjohnr
Copy link
Member

sjohnr commented Dec 28, 2023

The Java Configuration and Kotlin Configuration examples in the docs use the authorizeRequests DSL method. These examples should be updated to use authorizeHttpRequests instead.

@sjohnr sjohnr added in: docs An issue in Documentation or samples type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Dec 28, 2023
@andreilisa
Copy link

I have seen related stack overflow answer where you pointed to this ticket , Can I take it ?

@Siddharth1605
Copy link
Contributor

As none has been assigned yet, I'd like to contribute to this issue. I have understood the issue, and I have also rectified the issue in the documentation.

@sjohnr
Copy link
Member Author

sjohnr commented Dec 29, 2023

Thanks @andreilisa and @Siddharth1605 for volunteering!

I see that @Siddharth1605 has already opened a PR for this, so I will assign the issue to you. However, in the future please be mindful of others who have already asked to take the ticket as @andreilisa did.

@Siddharth1605
Copy link
Contributor

@sjohnr and @andreilisa sorry for the above concern. I'm new to this open-source contribution, there by in the future it wont happen like this again.

sjohnr added a commit that referenced this issue Dec 29, 2023
sjohnr added a commit that referenced this issue Dec 29, 2023
@sjohnr sjohnr closed this as completed in e11ed2d Dec 29, 2023
@sjohnr sjohnr added this to the 6.1.7 milestone Dec 29, 2023
@sjohnr sjohnr added status: duplicate A duplicate of another issue and removed status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants