Skip to content

Document that @DnAttribute only works on String fields #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2019
Merged

Document that @DnAttribute only works on String fields #500

merged 1 commit into from
Jan 25, 2019

Conversation

edysli
Copy link
Contributor

@edysli edysli commented Jan 25, 2019

Fixes #499.

@pivotal-issuemaster
Copy link

@edysli Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@edysli Thank you for signing the Contributor License Agreement!

@rwinch rwinch merged commit 81604a8 into spring-projects:master Jan 25, 2019
@rwinch rwinch self-assigned this Jan 25, 2019
@rwinch rwinch added type: enhancement in: docs An issue in Documentation or samples labels Jan 25, 2019
@rwinch rwinch added this to the 2.3.3 milestone Jan 25, 2019
@rwinch
Copy link
Member

rwinch commented Jan 25, 2019

Thanks for the PR @edysli! This is now merged into master

@edysli
Copy link
Contributor Author

edysli commented Jan 25, 2019

Thank you @rwinch! 😄

@edysli edysli deleted the issue-499 branch January 28, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
in: docs An issue in Documentation or samples type: enhancement
Projects
None yet
Milestone
2.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@edysli @pivotal-issuemaster @rwinch