Skip to content

Adjust CustomHypermediaType so it produces HAL-like JSON #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregturn opened this issue Apr 5, 2020 · 1 comment
Open

Adjust CustomHypermediaType so it produces HAL-like JSON #1260

gregturn opened this issue Apr 5, 2020 · 1 comment
Assignees
Labels
in: infrastructure Build infrastructure and dependency upgrades in: mediatypes Media type related functionality

Comments

@gregturn
Copy link
Contributor

gregturn commented Apr 5, 2020

More and more, people are using our test example, CustomHypermediaType, to produce HAL-like JSON, but served under a different media type.

To avoid questions like, "why doesn't this produce the right JSON", it makes sense to properly register all the parts of HAL.

From a project perspective, it only alters some test cases. But from an example perspective, it should be quite handy.

@gregturn gregturn added in: infrastructure Build infrastructure and dependency upgrades in: mediatypes Media type related functionality labels Apr 5, 2020
@gregturn gregturn added this to the 1.1.0.M4 milestone Apr 5, 2020
@gregturn gregturn self-assigned this Apr 5, 2020
gregturn added a commit that referenced this issue Apr 5, 2020
By having this custom hypermedia type register ALL the parts of the HAL Jackson module, it provides a better example to users that wish to serve a custom media type that is HAL-like.

Related issues: #1259, #1253
@odrotbohm
Copy link
Member

I don't think we should tweak our tests in that direction. The addition of a custom media type is more than just supporting a different name for an already supported one. By moving the custom media type used in the test closer to HAL we risk the test to stay green if we change something in the custom media type activation code in a way that loses that custom declaration but rather exposes existing HAL support.

I'll chime in on the original discussion in a moment.

@gregturn gregturn modified the milestones: 1.1.0.RC1, 1.2.0-M1 Apr 21, 2020
@odrotbohm odrotbohm modified the milestones: 1.2 M1, 1.2 RC1 Aug 11, 2020
@gregturn gregturn modified the milestones: 1.2 RC1, 1.2 GA Sep 15, 2020
@odrotbohm odrotbohm modified the milestones: 1.2 GA, 1.3 M1 Oct 27, 2020
@odrotbohm odrotbohm modified the milestones: 1.3 M1, 1.3 M2 Jan 13, 2021
@odrotbohm odrotbohm modified the milestones: 1.3 M2, 1.3 RC1 Feb 16, 2021
@odrotbohm odrotbohm modified the milestones: 1.3 M3, 1.4 M1 Mar 15, 2021
@odrotbohm odrotbohm modified the milestones: 1.4 M1, 1.4 M2 Jul 14, 2021
@odrotbohm odrotbohm modified the milestones: 1.4 M2, 1.4 M3 Aug 12, 2021
@odrotbohm odrotbohm modified the milestones: 1.4 M3, 1.4 candidates Sep 16, 2021
@odrotbohm odrotbohm removed this from the 1.4 candidates milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: infrastructure Build infrastructure and dependency upgrades in: mediatypes Media type related functionality
Projects
None yet
Development

No branches or pull requests

2 participants