Skip to content

Allow ContentResultMatchersDsl matchers for supertypes of the checked type #34542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dmitrysulman
Copy link
Contributor

@dmitrysulman dmitrysulman commented Mar 5, 2025

This PR allows accepting Matcher<CharSequence> for ContentResultMatchersDsl#string.

Before:

fun string(matcher: Matcher<String>)

After:

fun string(matcher: Matcher<in String>)

Fixes gh-34494

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 5, 2025
… type

See spring-projectsgh-34494

Signed-off-by: Dmitry Sulman <dmitry.sulman@gmail.com>
@dmitrysulman dmitrysulman changed the title Allow ContentResultMatchersDsl matchers for supertypes of the checked type Allow ContentResultMatchersDsl matchers for supertypes of the checked type Mar 5, 2025
@dmitrysulman
Copy link
Contributor Author

@sdeleuze I would appreciate any feedback on this PR.

@sdeleuze sdeleuze self-assigned this Mar 7, 2025
@sdeleuze sdeleuze added type: enhancement A general enhancement theme: kotlin An issue related to Kotlin support and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 7, 2025
@sdeleuze sdeleuze added this to the 6.2.4 milestone Mar 7, 2025
sdeleuze pushed a commit to sdeleuze/spring-framework that referenced this pull request Mar 7, 2025
Closes spring-projectsgh-34542
Signed-off-by: Dmitry Sulman <dmitry.sulman@gmail.com>
@sdeleuze sdeleuze closed this in a6f3f18 Mar 7, 2025
@sdeleuze
Copy link
Contributor

sdeleuze commented Mar 7, 2025

Merged, thanks.

@sdeleuze sdeleuze added the in: test Issues in the test module label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module theme: kotlin An issue related to Kotlin support type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContentResultMatchersDsl's matchers too strict
3 participants