Skip to content

Default @Query(sort) not applied for repository queries using keyset pagination #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mp911de opened this issue Aug 2, 2024 · 0 comments
Assignees
Labels
type: bug A general bug

Comments

@mp911de
Copy link
Member

mp911de commented Aug 2, 2024

Using a query such as

@Query(value = "{country:  'USA'}", sort = "{lastName:  -1, firstName: -1}")
Window<Person> findBy(Limit limit, ScrollPosition scrollPosition);

does not apply the default sort for keyset pagination because the decorated query proxy doesn't handle the isSorted method used by ScrollUtils.

@mp911de mp911de added the type: bug A general bug label Aug 2, 2024
@mp911de mp911de added this to the 4.2.9 (2023.1.9) milestone Aug 2, 2024
mp911de added a commit that referenced this issue Aug 2, 2024
mp911de added a commit that referenced this issue Aug 2, 2024
Reformat code.

See #4758
@mp911de mp911de self-assigned this Aug 2, 2024
mp911de added a commit that referenced this issue Aug 12, 2024
mp911de added a commit that referenced this issue Aug 12, 2024
Reformat code.

See #4758
Original pull request: #4759
mp911de added a commit that referenced this issue Aug 12, 2024
mp911de added a commit that referenced this issue Aug 12, 2024
Reformat code.

See #4758
Original pull request: #4759
@mp911de mp911de linked a pull request Aug 12, 2024 that will close this issue
@mp911de mp911de closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant