Skip to content

Clarify transaction boundary recommendation #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pch8388
Copy link
Contributor

@pch8388 pch8388 commented Apr 16, 2025

This PR clarifies the intent of the documentation regarding the usage of @Transactional in the repository layer.

It adds a note to explain that while the example shows @Transactional on repository methods for read-only defaults, it is generally recommended to define transaction boundaries at the service layer to reflect business logic and ensure proper control.

Fixes #3842

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 16, 2025
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 17, 2025
@mp911de mp911de self-assigned this Apr 17, 2025
@mp911de mp911de added this to the 3.3.11 (2024.0.11) milestone Apr 17, 2025
@mp911de mp911de changed the title Clarify transaction boundary recommendation for @Transactional usage Clarify transaction boundary recommendation Apr 17, 2025
mp911de pushed a commit that referenced this pull request Apr 17, 2025
mp911de added a commit that referenced this pull request Apr 17, 2025
Tweak wording.

See #3842
Original pull request: #3843
mp911de pushed a commit that referenced this pull request Apr 17, 2025
mp911de added a commit that referenced this pull request Apr 17, 2025
Tweak wording.

See #3842
Original pull request: #3843
mp911de pushed a commit that referenced this pull request Apr 17, 2025
mp911de added a commit that referenced this pull request Apr 17, 2025
Tweak wording.

See #3842
Original pull request: #3843
@mp911de
Copy link
Member

mp911de commented Apr 17, 2025

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Apr 17, 2025
@mp911de
Copy link
Member

mp911de commented Apr 17, 2025

Please mind to DCO-sign your commits for future pull requests.

@pch8388
Copy link
Contributor Author

pch8388 commented Apr 17, 2025

Thank you for reviewing and merging the PR!
I’m glad I could help improve the documentation even a little.
Looking forward to contributing again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify transaction boundary recommendation
3 participants