Skip to content

Introduce PersistentProperty.isReadable #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Introduce PersistentProperty.isReadable #2916

wants to merge 3 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Aug 28, 2023

isReadable reports whether a property can be read through PersistentPropertyAccessor, by either using property access through setters, a wither, Kotlin Copy method or by accessing the field directly.

Closes #2915

mp911de added 3 commits August 28, 2023 11:34
@mp911de
Prepare issue branch.
8664a4c
@mp911de
Introduce PersistentProperty.isReadable.
2e4ad19 
isReadable reports whether a property can be read through PersistentPropertyAccessor, by either using property access through setters, a wither, Kotlin Copy method or by accessing the field directly.

Closes #2915
@mp911de
Polishing.
48f7843 
Fix Javadoc references.

See #2915
@mp911de mp911de added the type: enhancement A general enhancement label Aug 28, 2023
@mp911de mp911de added this to the 3.2 M3 (2023.1.0) milestone Aug 28, 2023
odrotbohm
odrotbohm reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@odrotbohm odrotbohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lack of the method is probably an oversight, as I generally like symmetry in method declarations. Some inline questions regarding the documentation though.

mp911de added a commit that referenced this pull request Aug 31, 2023
@mp911de
Introduce PersistentProperty.isReadable.
df543cd 
isReadable reports whether a property can be read through PersistentPropertyAccessor, by either using property access through setters, a wither, Kotlin Copy method or by accessing the field directly.

Closes #2915
Original pull request: #2916
mp911de added a commit that referenced this pull request Aug 31, 2023
@mp911de
Polishing.
8c342a5 
Fix Javadoc references.

See #2915
Original pull request: #2916
@mp911de mp911de closed this Aug 31, 2023
@mp911de mp911de deleted the issue/2915 branch August 31, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odrotbohm odrotbohm odrotbohm left review comments

@christophstrobl christophstrobl Awaiting requested review from christophstrobl

Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.2 M3 (2023.1.0)
Development

Successfully merging this pull request may close these issues.

Introduce PersistentProperty.isReadable
2 participants
@mp911de @odrotbohm