Skip to content

Spring Data reference documentation misses information about Limit #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sergey-morenets opened this issue Nov 24, 2023 · 1 comment
Closed

Spring Data reference documentation misses information about Limit #3006

sergey-morenets opened this issue Nov 24, 2023 · 1 comment
Assignees
@christophstrobl
Labels
type: documentation A documentation update
Milestone
3.2.1 (2023.1.1)

Comments

@sergey-morenets
Copy link

Hi

Spring Data JPA introduces new type Limit that allows to do dynamical limiting. But i couldn't find any information about its usage and examples in the reference documentation:

https://docs.spring.io/spring-data/jpa/reference/repositories/query-methods-details.html
https://docs.spring.io/spring-data/jpa/reference/jpa/query-methods.html
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 24, 2023
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 27, 2023
@christophstrobl
Copy link
Member

The Limit parameter is documented in the Paging, Iterating Large Results, Sorting & Limiting section which is inherited from data-commons. Reading the two section reveals we should revisit and potentially unite them into one.

@christophstrobl christophstrobl transferred this issue from spring-projects/spring-data-jpa Dec 14, 2023
@christophstrobl christophstrobl linked a pull request Dec 14, 2023 that will close this issue
Add Limit parameter to section in reference documentation. #3007
Closed
@mp911de mp911de changed the title Spring Data JPA reference documentation misses information about Limit Spring Data reference documentation misses information about Limit Dec 15, 2023
@mp911de mp911de added this to the 3.2.1 (2023.1.1) milestone Dec 15, 2023
mp911de pushed a commit that referenced this issue Dec 15, 2023
@christophstrobl @mp911de
Add Limit parameter to section in reference documentation.
d3a56e6 
Closes #3006
Original pull request: #3007
mp911de added a commit that referenced this issue Dec 15, 2023
@mp911de
Polishing.
f0bc54a 
Fix letter casing.

See #3006
Original pull request: #3007
mp911de added a commit that referenced this issue Dec 15, 2023
@mp911de
Polishing.
565fc99 
Fix letter casing.

See #3006
Original pull request: #3007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: documentation A documentation update
Projects
None yet
Milestone
3.2.1 (2023.1.1)
Development

Successfully merging a pull request may close this issue.

Add Limit parameter to section in reference documentation. spring-projects/spring-data-commons
5 participants
@gregturn @mp911de @christophstrobl @sergey-morenets @spring-projects-issues