Skip to content

Avoid records as cache keys for GraalVM performance reasons #2997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odrotbohm opened this issue Dec 5, 2023 · 0 comments
Closed

Avoid records as cache keys for GraalVM performance reasons #2997

odrotbohm opened this issue Dec 5, 2023 · 0 comments
Assignees
@odrotbohm
Labels
type: enhancement A general enhancement
Milestone
3.1.7 (2023.0.7)

Comments

@odrotbohm
Copy link
Member

odrotbohm commented Dec 5, 2023 •
edited
Loading

As reported here, cache key implemented as records have a sever impact on the performance of applications running on GraalVM as the relevant methods are implemented using reflection (original ticket in GraalVM here). For the time being, we should revert to use simple classes to avoid that penalty for the caches we use internally.
@odrotbohm odrotbohm added the type: enhancement A general enhancement label Dec 5, 2023
@odrotbohm odrotbohm added this to the 3.1.7 (2023.0.7) milestone Dec 5, 2023
@odrotbohm odrotbohm self-assigned this Dec 5, 2023
odrotbohm added a commit that referenced this issue Dec 5, 2023
@odrotbohm
Avoid records as cache keys for performance reasons.
e864c57 
Fixes GH-2997.
odrotbohm added a commit that referenced this issue Dec 5, 2023
@odrotbohm
Avoid records as cache keys for performance reasons.
207b5f6 
Fixes GH-2997.
odrotbohm added a commit that referenced this issue Dec 5, 2023
@odrotbohm
Avoid records as cache keys for performance reasons.
ba4526e 
Fixes GH-2997.
odrotbohm added a commit that referenced this issue Dec 5, 2023
@odrotbohm
Avoid records as cache keys for performance reasons.
0cf2538 
Fixes GH-2997.
odrotbohm added a commit that referenced this issue Dec 5, 2023
@odrotbohm
Avoid records as cache keys for performance reasons.
02fccfe 
Fixes GH-2997.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.1.7 (2023.0.7)
Development

No branches or pull requests
1 participant
@odrotbohm