Skip to content

Invalid @NonNullApi [DATACMNS-1616] #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Nov 14, 2019 · 1 comment
Closed

Invalid @NonNullApi [DATACMNS-1616] #2044

spring-projects-issues opened this issue Nov 14, 2019 · 1 comment
Assignees
Labels
in: core Issues in core support type: bug A general bug

Comments

@spring-projects-issues
Copy link

James Howe opened DATACMNS-1616 and commented

There are some APIs that are designed to work with nulls, but are in packages annotated with @NonNullApi. This generates static analysis warning for any implementers / extenders.

I've not done an exhaustive search, but one example is o.s.d.querydsl.binding.SingleValueBinding#bind

Returns:
can be null, in which case the binding will not be incorporated in the overall Predicate .

Attempting to return null will be treated as a mistake


Affects: 2.2.1 (Moore SR1)

@spring-projects-issues
Copy link
Author

James Howe commented

Related: I've also just noticed MultiValueBinding has the same documented return, even though it returns an Optional

@spring-projects-issues spring-projects-issues added type: bug A general bug in: core Issues in core support labels Dec 30, 2020
@mp911de mp911de assigned mp911de and unassigned odrotbohm Jan 22, 2025
@mp911de mp911de added this to the 3.3.9 (2024.0.9) milestone Jan 22, 2025
mp911de added a commit that referenced this issue Jan 22, 2025
mp911de added a commit that referenced this issue Jan 22, 2025
mp911de added a commit that referenced this issue Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core support type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants