Skip to content

Add spring.kafka.consumer.max-poll-interval configuration property #44901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add spring.kafka.consumer.max-poll-interval configuration property #44901

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Mar 26, 2025

I think max.poll.interval.ms is more important than max.poll.records which has its own configuration property key.

Feel free to close if the team disagree.

@quaff
Add configuration property key "spring.kafka.consumer.max-poll-interval"
4b0d987 
It's an important configuration property which deserve its own key instead of `spring.kafka.consumer.properties[max.poll.interval.ms]`.

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 26, 2025
@wilkinsona
Copy link
Member

Thanks, @quaff. Kafka defines both max.poll.records and max.poll.interval.ms as medium importance configuration options. Given that we have a property for one of them, I see no reason not to add the other.

@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 26, 2025
@wilkinsona wilkinsona added this to the 3.5.x milestone Mar 26, 2025
@wilkinsona wilkinsona changed the title Add configuration property key "spring.kafka.consumer.max-poll-interval" Add spring.kafka.consumer.max-poll-interval configuration property Mar 26, 2025
@mhalbritter mhalbritter self-assigned this Mar 26, 2025
mhalbritter pushed a commit that referenced this pull request Mar 26, 2025
@quaff @mhalbritter
Add 'spring.kafka.consumer.max-poll-interval' configuration property
4e1fa66 
See gh-44901

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@mhalbritter
Copy link
Contributor

Thanks @quaff !

@mhalbritter mhalbritter modified the milestones: 3.5.x, 3.5.0-RC1 Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@quaff @wilkinsona @mhalbritter @spring-projects-issues