Skip to content

Add support for LdapContextSource#referral property #44850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add support for LdapContextSource#referral property #44850

wants to merge 2 commits into from

Conversation

dobrosi
Copy link
Contributor

@dobrosi dobrosi commented Mar 23, 2025

…on.java`

@dobrosi
New LdapAutoConfiguration.referral property in `LdapAutoConfigurati…
62aecfd 
…on.java`

Signed-off-by: Andras, Dobrosi <dobrosi@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 23, 2025
@snicoll snicoll changed the title New LdapAutoConfiguration.referral property in `LdapAutoConfigurati… Add support for LdapContextSource#referral property Mar 24, 2025
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 24, 2025
@snicoll snicoll added this to the 3.5.x milestone Mar 24, 2025
@wilkinsona
Copy link
Member

Looking at the javadoc of javax.naming.Context.REFERRAL, an enum with values FOLLOW, IGNORE, and THROW could be useful here. We'd map them to the strings follow, ignore, and throw.

@snicoll
Copy link
Member

snicoll commented Mar 24, 2025 •
edited
Loading

@dobrosi would you like to update your PR in that direction? It's about creating that enum (with appropriate javadoc) in LdapProperties and then map to the underlying property.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Mar 24, 2025
@dobrosi
Copy link
Contributor Author

dobrosi commented Mar 24, 2025

Thanks. I create an enum for this refferal field.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Mar 24, 2025
@wilkinsona wilkinsona added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Mar 24, 2025
@dobrosi
Enum for referral field in LdapProperties.java
00d61a0 
Signed-off-by: Andras, Dobrosi <dobrosi@gmail.com>
@snicoll snicoll self-assigned this Mar 24, 2025
@snicoll snicoll removed the status: waiting-for-feedback We need additional information before we can continue label Mar 24, 2025
@snicoll snicoll modified the milestones: 3.5.x, 3.5.0-RC1 Mar 24, 2025
snicoll pushed a commit that referenced this pull request Mar 24, 2025
@dobrosi @snicoll
Add support for configuring LDAP's referral property
59705ed 
See gh-44850

Signed-off-by: Andras, Dobrosi <dobrosi@gmail.com>
snicoll added a commit that referenced this pull request Mar 24, 2025
@snicoll
Polish "Add support for configuring LDAP's referral property"
686628d 
See gh-44850
@snicoll snicoll closed this in 7821cb8 Mar 24, 2025
@snicoll
Copy link
Member

snicoll commented Mar 24, 2025

@dobrosi thanks very much, and congrats for making your first contribution to Spring Boot.

@dobrosi
Copy link
Contributor Author

dobrosi commented Mar 24, 2025

Thank you and I'm happy to help this great community with this little piece of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@dobrosi @wilkinsona @snicoll @spring-projects-issues