This repository was archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
executors: Add support for private docker registries #45488
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aea60c8
to
144f885
Compare
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 35e171e and 8c996a7 or learn more. Open explanation
|
144f885
to
096e709
Compare
Codenotify: Notifying subscribers in CODENOTIFY files for diff 8c996a7...35e171e.
|
evict
approved these changes
Dec 14, 2022
Piszmog
approved these changes
Dec 14, 2022
TODOs: - Documentation - Make env var take precedence, potentially could merge env and secret - Code intel secrets - Test firecracker - Generalize appending the secret, not do it in the batches transformer - Add support in src-cli exec mode for this env var (only native execution is working right now)
7a8dede
to
d3939c1
Compare
BolajiOlajide
approved these changes
Dec 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for private registries to executors, so for code intel auto-indexing and server-side batch changes.
It does so by introducing a new environment variable and a magic secret DOCKER_AUTH_CONFIG that can be set to authenticate to a protected docker registry. See the inline docs change for how this works exactly. I've also added storybooks coverage for the new components, so make sure to check out the UI review check.
There are two pending TODOs left but they shouldn't affect the code much so opening up for review now to get eyes on this!
Pending TODOs:
Sister PRs:
Closes https://github.com/sourcegraph/sourcegraph/issues/40479
Test plan
Verified all documented variants work locally and will test before merge on a dogfood instance to verify firecracker works as well.