Don't wrap request bodies if they are already Readables #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to wrap request bodies if they already conform to the
::Protocol::HTTP::Body::Readable
interface. This way developers can use other kinds ofReadable
s directly when making calls withFaraday
.Use-case: We need to make several requests to an API with chunks of a file in specific byte ranges.
Protocol::HTTP::Body::File
(from https://github.com/socketry/protocol-http) seems like a good candidate for this:Types of Changes
Contribution